Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metricscaler_test not cleaning up properly #492

Open
leahecole opened this issue Jan 19, 2022 · 0 comments
Open

metricscaler_test not cleaning up properly #492

leahecole opened this issue Jan 19, 2022 · 0 comments
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@leahecole
Copy link
Contributor

https://github.com/googleapis/python-bigtable/blob/main/samples/metricscaler/metricscaler_test.py is leaving leftovers in the test project which is increasing project costs.

Please ensure this isn't caused by underlying test failures, and use finally to ensure resource teardown occurs regardless of test outcome (see authoring guide for an example)
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jan 19, 2022
@leahecole leahecole added samples Issues that are directly related to samples. and removed api: bigtable Issues related to the googleapis/python-bigtable API. labels Jan 19, 2022
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jan 20, 2022
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 20, 2022
@kolea2 kolea2 added the type: cleanup An internal cleanup or hygiene concern. label Feb 22, 2022
@yoshi-automation yoshi-automation removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
3 participants
@leahecole @yoshi-automation @kolea2