You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code style is not consistently used, and the lack of proper indentation makes navigation and modification hard and error-prone. I propose using clang-format to convert all source files to an common style, and enforce the new style in the CI.
There are some predefined styles we can choose from (LLVM, GNU, Google, Chromium, Microsoft, Mozilla, WebKit) or it is possible to create a custom .clang-format file.
I can volunteer to implement this proposal if there is enough interest.
The text was updated successfully, but these errors were encountered:
Maybe as a warning, but in my experience the output of clang-format isn't super consistent between versions and I wouldn't want CI to become flaky because of this.
Sorry, I was looking at an older version of gtkwave, didn't noticed that it was already reformated. As for running clang-format in the CI, a warning would be enough in my opinion.
The code style is not consistently used, and the lack of proper indentation makes navigation and modification hard and error-prone. I propose using
clang-format
to convert all source files to an common style, and enforce the new style in the CI.There are some predefined styles we can choose from (LLVM, GNU, Google, Chromium, Microsoft, Mozilla, WebKit) or it is possible to create a custom .clang-format file.
I can volunteer to implement this proposal if there is enough interest.
The text was updated successfully, but these errors were encountered: