Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests (angular compliant) #45

Open
Brictarus opened this issue Dec 27, 2017 · 2 comments
Open

Add tests (angular compliant) #45

Brictarus opened this issue Dec 27, 2017 · 2 comments

Comments

@Brictarus
Copy link

Angular projects bootstrapped with angular-cli are initialized with basic jasmine tests. You really should add some tests examples in this example project to show people how to test their leaflet/angular application. It can be really tricky to check the map or tool states...

@haoliangyu
Copy link
Owner

@Brictarus Thanks for the suggestion. This project was developed before I knew angular-cli. So the current folder may be different from the requirement of angular-cli and it is the reason why I did not introduce angular-cli. But I will move back to front-end development soon and definitely try angular 5 and angular-cli with Leaflet at that time (maybe in a new example project).

Front-end testing is certainly a need but it is challenging with map. I have been working in GIS/map development for a few years and have not seen a good solution or general guideline on it. If you have any suggestion, please let me know (particularly on what to test, given that I am a seasonal front-end dev and not very familiar with this area).

@haoliangyu
Copy link
Owner

Update

Since angular-cli has been introduced into this project, we can use all standard tools and examples to write front-end tests now. Currently, tests in the code are automatically generated by angular-cli and not tuned for a map application. I will continue to see what I can do with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants