Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #127 #218

Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix: #127 #218

merged 1 commit into from
Aug 18, 2021

Conversation

yihong0618
Copy link
Collaborator

No description provided.

@yvetterowe yvetterowe mentioned this pull request Aug 18, 2021
Closed
hozn
hozn reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@hozn hozn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will tweak this slightly to use six.text_type, but thanks for demonstrating the fix.
@hozn hozn merged commit 6fd2089 into stravalib:master Aug 18, 2021
@hozn hozn added this to the 0.10.4 milestone Aug 18, 2021
hozn added a commit that referenced this pull request Aug 18, 2021
@hozn
Tweak to fix for unicode bug with python3 (#217, #218)
b76e14e
@hozn
Copy link
Collaborator

hozn commented Aug 18, 2021

Thanks again -- pushed out 0.10.4.
@yihong0618
Copy link
Collaborator Author

yihong0618 commented Aug 18, 2021 •
edited
Loading

@hozn Thank you for this great repo.~
@yihong0618 yihong0618 mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@yihong0618 @hozn