Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time blocking Search Results #97

Open
cparish312 opened this issue May 14, 2024 · 3 comments
Open

Time blocking Search Results #97

cparish312 opened this issue May 14, 2024 · 3 comments
Labels
enhancement New feature or request Requires Planning

Comments

@cparish312
Copy link
Contributor

From my experience, it may be more useful to only return one result per time block of some length when searching. Currently, all frames with the text are returned, so this means there are often dozens of frames from really the same "instance" of the found text.

I'm thinking return the most recent frame within a 10 minute block or something like that?

Rewind does something along these lines, and it's pretty helpful!

@jasonjmcghee
Copy link
Owner

Maybe there's a grouped view? Like each row is a bucket of matching frames in order that are within some time frame?

We skip taking screenshots if OCR returned the exact same result fwiw (assuming the setting is enabled).

@cparish312
Copy link
Contributor Author

Grouped view could be good! A little worries it would still be cluttered and you could only have a couple groups at once. Another option could be groups by time and when you click on the frame group it shows all frames within.

Oh cool! Where is that skipping implemented I can't find it?

@jasonjmcghee
Copy link
Owner

You know, I partially retract - that's what I wrote on a branch, but opted to instead do pixel perfect comparison:

private func displayImageChangedFromLast(imageData: Data) -> Bool {

I ended up not doing the OCR comparison approach as I was concerned about things like photoshop, blender, etc. having high frame loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Requires Planning
2 participants