Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing to remember #99

Open
DmacMcgreg opened this issue May 22, 2024 · 26 comments
Open

Nothing to remember #99

DmacMcgreg opened this issue May 22, 2024 · 26 comments

Comments

@DmacMcgreg
Copy link

CleanShot 2024-05-22 at 19 12 51@2x

Steps to reproduce:

  1. Install app
  2. Start remembering
  3. Do some things
  4. Stop remembering
  5. View timeline

It seems copying context is able to work.

Here is what search looks like:

CleanShot 2024-05-22 at 19 13 47@2x

@jasonjmcghee
Copy link
Owner

Did you build this yourself, or was it 0.13?

@DmacMcgreg
Copy link
Author

0.1.13 from the releases

@jasonjmcghee
Copy link
Owner

Could I trouble you to try out this release?

https://github.com/jasonjmcghee/rem/releases/tag/v0.1.14

@DmacMcgreg
Copy link
Author

Same issue. I purged all data also.

@DmacMcgreg
Copy link
Author

Happy to help debug if needed, or to provide some logs.

@cparish312
Copy link
Contributor

Hey @DmacMcgreg , if you click on "Show Me My Data" do the mp4 videos seem to be playable? They should just be sped up recordings of your screen.

@mkielo3
Copy link

mkielo3 commented May 31, 2024

Hello, I am having the same issue (on v 0.1.14). I noticed a few other things:

If I use an external monitor only:

  • .mp4 files are created, but have 0 size
  • toggle timeline is empty

If I use notebook monitor only:

  • .mp4 files contain data and play as expected
  • toggle timeline freezes my computer (but I can return to normal by pressing escape)

Very cool tool so I'm hoping this might help!

@mkielo3
Copy link

mkielo3 commented May 31, 2024

Ok this is a bit odd. After removing the external monitor, using Rem for a few minutes, and then plugging the external monitor back into the tool seems to be working as expected. My settings are:

image
@DmacMcgreg
Copy link
Author

Also getting the 0kb videos
Also using external monitor with laptop closed.

CleanShot 2024-05-31 at 10 42 08@2x

@cparish312
Copy link
Contributor

Yeah so I added a bunch of features for external monitor support. I recommend using "always record window with mouse" and this also makes "only OCR region of active window" unusable unfortunately. Checkout #93 for more details and lmk if that resolves it!

@jasonjmcghee
Copy link
Owner

jasonjmcghee commented May 31, 2024

@cparish312 if this fixes it, I think we should prompt the user to address this or force this behavior if there's an external monitor, or they will have this experience

@mkielo3 - can you confirm- does timeline "freeze your computer", or is it just a full screen screenshot? (Try swiping with two fingers left or right)

@mkielo3
Copy link

mkielo3 commented May 31, 2024

Thanks for such fast replies! It seems like a few things going on:

  • If you open timeline without any saved recordings it creates the appearance of freezing your computer. My guess it there is no image to display so the user simply sees their regular desktop.
  • There doesn't seem to be a way to scroll through the timeline without a trackpad. My set up is: laptop closed + external monitor + keyboard + mouse -- in this case I can't seem to scroll through timeline?
  • If I switch to using the laptop only, the timeline works as expected (with swipe to scroll)
@jasonjmcghee
Copy link
Owner

It should show the placeholder as seen above in this issue if there are no recordings 🤔


Seems like supporting the mouse wheel is a no-brainer.

Could also do arrow keys.

I'll log this as a separate issue.

@mkielo3
Copy link

mkielo3 commented May 31, 2024

Strange - I definitely didn't see the "nothing to remember" message. Possibly has to do with having multiple zero-byte mp4 files saved? In any case - things seem to be working now. Thanks again!

@DmacMcgreg
Copy link
Author

@cparish312 I have both those selected and unfortunately it still doesn't work. Curiously when I purge my data, I still have data from a week ago.. Should I delete the db.sqlite file as well? seems it didn't get deleted.

@DmacMcgreg
Copy link
Author

Deleted sqlite database and same deal, still 0 byte mp4 videos.

@cparish312
Copy link
Contributor

Hmmm yeah not sure what is causing the 0 byte mp4s. The purge should purge everything including the db.sqlite file so that is very strange. Could you try:

  1. Quitting rem
  2. manually deleting everything in the data directory
  3. Restarting rem with the "always record window with mouse"

There has been very limited testing of the external monitor functionality so appreciate the perseverance!

@cparish312
Copy link
Contributor

@DmacMcgreg Oh sorry just saw that you already tried deleting it. The inability to use the purge functionality makes me think it could be a permissions issue.

@cparish312
Copy link
Contributor

Some logs could be super helpful but unsure the best way to get them. See #101 (comment)

@mkielo3
Copy link

mkielo3 commented May 31, 2024

I did a bit more poking around here and hope this might be helpful. It seems like fresh installs need at least 1 recording with the laptop native display.

Case 1 (doesn't work)

Setup: external display attached, laptop closed. "Always record window with mouse" enabled. "Only OCR Region of active application" disabled.

  1. Install REM
  2. Begin recording
  3. Saves a bunch of zero byte MP4s

Case 2 (does work)

Setup: Laptop open with no external display. "Always record window with mouse" enabled. "Only OCR Region of active application" disabled.

  1. Install REM
  2. Begin recording
  3. Saves correct videos
  4. Reattach external display, videos continue to save correctly
@cparish312
Copy link
Contributor

Thank you for the testing! Not sure what is causing that, but I will try to replicate when I get a chance. @DmacMcgreg could you see if this resolves your issue.

@DmacMcgreg
Copy link
Author

@mkielo3 looks like you are correct!
I'm able to reproduce exactly as mentioned.
I did indeed have my laptop closed the entire time.

Also would add on the side that the timeline aspect is quite jarring, since you cannot really notice you've entered a playback mode, or where you are on the timeline of that playback, but otherwise very glad that it's working!!

@cparish312
Copy link
Contributor

cparish312 commented May 31, 2024

Awesome! Yeah I totally agree, I still sometimes get confused and think my computer is frozen when I accidentally enter the timeline. I worked on #41 for the little bit but was unable to create a cleaner solution. One double solution could be displaying the timelines on the images.

@DmacMcgreg
Copy link
Author

one of the better interfaces i've seen is that of ScreenMemory, which looks like this:
CleanShot 2024-05-31 at 13 47 24@2x

@jasonjmcghee
Copy link
Owner

jasonjmcghee commented Jun 3, 2024

The single most helpful thing you @DmacMcgreg and @mkielo3 could do here is set a breakpoint and step through and look for the failure.

One area I'm concerned about is

targetWidth: Int(NSScreen.main!.frame.width * NSScreen.main!.backingScaleFactor),

That theoretically should use whatever is considered "main" but I'm suspicious...

@qwertyus124
Copy link

I'm having the same issue but running a Mac Mini M2 Pro - just blank timeline and 0KB mp4 files. Obviously I need an external monitor since there's no built-in one, so not sure what the solution is. Running 0.1.14 on latest macOS Sonoma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants