MinBinaryHeap heapify calls compare function when unnecessary

[timvandam]

I'm talking about this call: https://github.com/jeffzh4ng/iruka/blob/02acaa0c621a6db9e874d6a7b4cc1bf2fd87f99a/src/data-structures/priority-queues/min-binary-heap.ts#L161

This call should not always happen here, as it can cause the compare function to be called with undefined values while the compare function should only receive whatever the generic heap value type is.

This is causing an issue for me when constructing a MinHeap with heapify as I'm storing key-value pairs in a length-2 array. My compare function ((a, b) => a[0] - b[0]) is being called even though indexOutOfBounds is true, which causes undefined to be passed as b, causing TypeError: Cannot read property '0' of undefined.

Inlining the function call fixes it:

const indexOutOfBounds = leftChildIndex >= this.size()
if (indexOutOfBounds || this.less(k, smallestIndex)) break

Alternatively the bound check can be put in the while condition