Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for cron expressions overlap #476

Open
jmrozanec opened this issue Apr 22, 2021 · 6 comments
Open

Test for cron expressions overlap #476

jmrozanec opened this issue Apr 22, 2021 · 6 comments

Comments

@jmrozanec
Copy link
Owner

Given the following expressions:

cron1 = "0 0 10 1/1 ? "; //everyday at 10am
cron2 = "0 0 10 ? MON "; //every monday at 10am

We would ideally want to test cron1.overlap(cron2) -> true

@diegoramosb
Copy link

Hi @jmrozanec! I'd like to work on this issue. Just to check if I understood the feature correctly, the overlap method would be declared in the Cron interface and would check the overlap between two objects that implement Cron, is that correct?

@jmrozanec
Copy link
Owner Author

@diegoramosb that is correct! 😄 We look forward to your PR! Greetings to Bogotá!

@diegoramosb
Copy link

Hey there! I just wanted to let you know that I'm still working on this issue. I've made progress on completing it, but it's way more complicated than I initially thought and I haven't been able to work on it for the last week or so.

@jmrozanec
Copy link
Owner Author

@diegoramosb we appreciate the status! 😄 Just send the PR when done, and we will be glad to merge and release a new version!

@jmrozanec jmrozanec added this to the next milestone Nov 1, 2021
@jmrozanec jmrozanec modified the milestones: 9.1.7, next Jul 16, 2022
@jiachengzhang1
Copy link

@jmrozanec has this feature been completed yet? I implemented something similar for work, I'd like to continue contributing on this if help is still needed.

@jmrozanec
Copy link
Owner Author

@jiachengzhang1 please, go ahead! The contribution is welcome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment