Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] url title reverts to file name #108

Closed
2084x opened this issue Dec 13, 2022 · 2 comments
Closed

[Bug] url title reverts to file name #108

2084x opened this issue Dec 13, 2022 · 2 comments

Comments

@2084x
Copy link
Contributor

2084x commented Dec 13, 2022

To reproduce:

  1. open two or more urls with mpv and open the playlist to check titles have resolved

pic-selected-221213-1224-21

  1. wait for first video to end or hit playlist next or hit enter on a playlist entry
  2. open playlist again and first entry will just be the file name

pic-selected-221213-1224-30

This is caused by f00137a. Revert to file-loaded and the url will resolve. This issue doesn't occur with local files as far as I know.
@jonniek
Copy link
Owner

jonniek commented Dec 13, 2022

Seems like the media title is not set yet at this point, since the url is still loading. I feel like there is a lot of issues that have stemmed from that start-file change.

I think reverting might cause some other issues since we have adjusted the code a few times already.

I think the correct fix is maybe to have both start-file and file-loaded.
@jonniek
Copy link
Owner

jonniek commented Dec 13, 2022 •
edited
Loading

Made a quick fix. Will take a closer look what belongs in which event later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@jonniek @2084x