Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page move down or up does not work #115

Closed
ghost opened this issue Jan 6, 2023 · 5 comments
Closed

page move down or up does not work #115

ghost opened this issue Jan 6, 2023 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 6, 2023

title say as it

@jonniek
Copy link
Owner

jonniek commented Jan 7, 2023

By not work do you mean nothing happens?

For me it moves up or down by the showamount which I assume was expected behaviour of the person who implemented it.

It has a weird effect when playlist is sliced from beginning and end though. Since the selection is in the middle and the logical page down would be ceiling(showamount / 2) for showamount of odd numbers. Is this what you would expect?

For example:

  ...
  File10
  File11
->File12
  File13
  File14
  ...

Would you expect page up and down to always jump to the next file in ...?

@ghost
Copy link
Author

ghost commented Jan 7, 2023

Ah I guess I misunderstood, my expectation was that I couldn't see which video to select because the list didn't fit on the screen, so I thought we were going to use pg down to bring that list down, fortunately I solved the problem by changing the size of the font, thank you for the help

@jonniek
Copy link
Owner

jonniek commented Jan 7, 2023

Yeah that's an annoying issue. I brought down the default showamount as a quick fix d43619d with some improvements to the rendering logic.

There is a duplicate #106 so I'll close this one.

@jonniek jonniek closed this as completed Jan 7, 2023
@tupo2
Copy link

tupo2 commented Jan 7, 2023

For me, with the last commit it only shows 8 entries instead of 9 by default.

@jonniek
Copy link
Owner

jonniek commented Jan 9, 2023

For me, with the last commit it only shows 8 entries instead of 9 by default.

I changed it to count the .... This way the playlist will always be at most showamount lines long instead of sometimes growing and shrinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants