Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

selects with an id containing a period don't open their popup #5893

Closed
thojo opened this issue Apr 17, 2013 · 0 comments
Closed

selects with an id containing a period don't open their popup #5893

thojo opened this issue Apr 17, 2013 · 0 comments
Labels
Component: Popup Component: Selectmenu
Milestone
1.3.2

Comments

@thojo
Copy link

thojo commented Apr 17, 2013

Clicking on selects with data-native-menu="false" and an id containing a period like id="select1.id" does not show the menu/popup.
In version 1.1.1, it still worked.

1.3.0: http://jsbin.com/opegav/1
1.1.1: http://jsbin.com/afesef/1
Both with jQuery 1.7.2.
gabrielschulhof pushed a commit that referenced this issue Apr 17, 2013
Custom select: Escape weird characters in popup/dialog ID when they b…
83e14b9 
…ecome hrefs. Fixes #5893.

(cherry picked from commit f0b2417)
gabrielschulhof pushed a commit that referenced this issue Apr 18, 2013
Tests: Integration: Custom select: Modify ID to contain a period. Tests
1b42813 
#5893.
gabrielschulhof pushed a commit that referenced this issue Apr 30, 2013
Revert "Custom select: Escape weird characters in popup/dialog ID whe…
513c1bf 
…n they become hrefs. Fixes #5893."

This reverts commit f0b2417.

Conflicts:
	js/widgets/forms/select.custom.js

It is better to set the href to something valid rather than something that has escaped characters. The responsibility for correctly identifying elements based on a valid href goes to navigation/popup.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Popup Component: Selectmenu
1 participant
@thojo