Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active State for menus in 1.13.0 with Smoothness Theme #2033

Open
noyearzero opened this issue Dec 13, 2021 · 6 comments
Open

Active State for menus in 1.13.0 with Smoothness Theme #2033

noyearzero opened this issue Dec 13, 2021 · 6 comments

Comments

@noyearzero
Copy link

The active state for menu items in the default theme has a blue background and all the other themes I checked makes the active item stand out visuall... but the smoothness theme only adds a light gray border. It's also different from how it looked in 1.12. I'm not sure if this is a bug or intentional. Either way, I think it could be improved.

@noyearzero
Copy link
Author

jquery ui default
jquery ui smoothness

@noyearzero
Copy link
Author

@mgol I'm wondering why the label "Behavior shared with 1.12" was added. For me it's different in that version as shown in the screenshots.

@mgol
Copy link
Member

mgol commented Jan 17, 2022

I have jQuery UI 1.12.1 in the Smoothness theme downloaded locally and it looks just like in 1.13.0, i.e. your second screenshot. Your first screenshot is the Base theme, isn't it?

Can you share screenshots of 1.12.1 & 1.13.0 in the same theme so that I can see what differs for you?

@noyearzero
Copy link
Author

noyearzero commented Jan 17, 2022

Oh yeah. I was having a hard time finding an example of Smoothness. The thing I was working on would have been quite difficult to revert, so I used the base. But I was able to find an example of what 1.12.1 looked like
image

I was wondering if maybe the issue lies in the theme builder itself?

@mgol
Copy link
Member

mgol commented Jan 20, 2022

This doesn't look like the smoothness theme to me. I still see no difference in what 1.12.1 & 1.13.0 look like, 1.12.1 is also not highlighted other than by adding a gray border. I'll leave the labels for now. If you find a difference, please post here & we can re-evaluate.

@noyearzero
Copy link
Author

Yeah, you might be right. I might have been a modified version of Smoothness because this issue previous existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment