Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code for Dialog is broken #2183

Closed
Hadakajime opened this issue Aug 22, 2023 · 4 comments
Closed

Sample code for Dialog is broken #2183

Hadakajime opened this issue Aug 22, 2023 · 4 comments
Labels

Comments

@Hadakajime
Copy link

All the samples for each type of Dialog screen here:
https://jqueryui.com/dialog

The main CSS file is incorrectly linked, resulting in the modal not working correctly, such as not being resizable and everything looking wrong.

The HTTP protocol is missing:
href="//code.jquery.com
<link rel="stylesheet" href="//code.jquery.com/ui/1.13.2/themes/base/jquery-ui.css">

@fnagel
Copy link
Member

fnagel commented Sep 4, 2023

This looks good to me on Windows with latest FF. Can you check again?

Using // is just a wildcard for both, http.// and https://.

@Hadakajime
Copy link
Author

save the source to a local file and it doesn't work:

image

@markvantilburg
Copy link
Contributor

markvantilburg commented Sep 28, 2023

firefox tries to load the file with file:// if opened locally

GET file://code.jquery.com/ui/1.13.2/themes/base/jquery-ui.css net::ERR_FILE_NOT_FOUND

Including this would fix the issue if the file is stored locally:
<base href="https://code.jquery.com">

But using https:// instead of // might be easier.

@mgol
Copy link
Member

mgol commented Apr 25, 2024

Thanks for the report; fixed in jquery/jqueryui.com@7945c96. It should be deployed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants