New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong code in the Custom event chapter #14

Closed

abdulapopoola opened this issue Jul 3, 2011 · 1 comment

abdulapopoola commented Jul 3, 2011

.bind('turnOff', function(e) {
$(this).removeClass('off').addClass('on');
});

This should be

.bind('turnOff', function(e) {
$(this).removeClass('on').addClass('off');
});

Member

addyosmani commented Oct 1, 2011

I've just reviewed both files in https://github.com/jquery/web-learn-jquery-com/tree/master/content/custom-events and the correct order of class removal (on => off) for turnOff appears to be in there at the moment. Closing.

addyosmani closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment