Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequireJS examples are outdated #25

Closed
millermedeiros opened this issue Oct 21, 2011 · 11 comments
Closed

RequireJS examples are outdated #25

millermedeiros opened this issue Oct 21, 2011 · 11 comments

Comments

@millermedeiros
Copy link

examples uses deprecated syntax and point to old sample files. A good start is the RequireJS documentation: http://requirejs.org/docs/jquery.html and also the Require-jquery example: https://github.com/jrburke/require-jquery

I've been using the "alternate integration" (described on the README) since it doesn't require a special build of RequireJS.

@addyosmani
Copy link
Member

@millermedeiros On a recent call we mentioned that we're either going to drop the RequireJS section for now or ask @jrburke to help write a slightly revised version if he has a chance. Would either you or him be up for helping update that section?

@millermedeiros
Copy link
Author

I probably won't have enough time to do it anytime soon (swamped with client projects and some open-source projects) I would probably remove that section for now (since it is outdated) and add a link to RequireJS documentation and @Integralist beginners guide

@Integralist
Copy link

Thanks for the mention @millermedeiros.

@addyosmani just so you know you can find the post on GitHub here: https://github.com/Integralist/Blog-Posts/blob/master/Beginners-guide-to-AMD-and-RequireJs.md (along with any of my other posts)

@addyosmani
Copy link
Member

Thanks for the head's up @Integralist and @millermedeiros!

At the moment we're trying to avoid linking to specific blog posts as we previously ran into a situation where jQuery.com was pointing to quite a large number and it became difficult to manage which were out of date and which weren't over time. @Integralist would you be okay with contributing your post on AMD to the jQuery learning site? The credits would point you and your article back as the source but it would just mean that if we needed to make any updates this could be done without needing to poke you every time :)

@Integralist
Copy link

@addyosmani Yeah that's ok with me, ta.

@jrburke
Copy link

jrburke commented Jan 9, 2012

Just chiming in that I'm happy to help with any proofing or if folks need clarification on usage. requirejs.org has a quick start here and a jQuery page, but I think @Integralist has a better "how does this fit in" for a traditional jQuery developer, so I also nominate his post.

@addyosmani
Copy link
Member

Cheers @Integralist!

@jrburke We always appreciate your input. Thanks for offering to help proof-read anything we work on in this area. I too agree @Integralist's post is a great starting point so we'll probably update it a little further and add.

@addyosmani
Copy link
Member

@Integralist We've started work on the learning site again and I just wanted to ping you in case you'd like to send through a PR with the content from your beginners guide to AMD and RequireJS. If not, we're happy to pull the content from the markdown file you linked us to but just wanted to check in advance :)

Cheers!

@Integralist
Copy link

@addyosmani That's cool. As long as my name & twitter/GitHub accounts are cited somewhere then go for it :-)

@Integralist
Copy link

@addyosmani Oh and send me a link so I can see the final work in all it's glory lol

@bobholt
Copy link
Member

bobholt commented Oct 16, 2012

In discussion with @ajpiano concluded that at this time, we're going to defer support for RequireJS. If we include it, it should not be descending from this issue.

If someone would like to add RequireJS, please create a new page and a pull request to incorporate new content wholesale.

@bobholt bobholt closed this as completed Oct 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment