Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dir on command line does not override dir in build.js #177

Closed
DashBDev opened this issue Jan 31, 2012 · 4 comments
Closed

dir on command line does not override dir in build.js #177

DashBDev opened this issue Jan 31, 2012 · 4 comments
Milestone

Comments

@DashBDev
Copy link

I have a default dir specified in my build.js, but I sometimes override it on the command line.

In file:

dir: '../../build/temp'

Command line:

node r-1.0.5.js -o site\build.js  dir=../../build/temp2/

Both temp and temp2 directories are created. temp2 has all the files in an un-optimized state, temp has just a handful of files.
The optimizer errors with "No such file or directory '.../build/temp/xxx.js'"

This same config and command line works fine in 1.0.2.
I'm using node 0.6.9

@jrburke
Copy link
Member

jrburke commented Feb 3, 2012

Thanks, looks like I goofed something there. I'll start a 1.0.6 release bucket because of this.

@jrburke
Copy link
Member

jrburke commented Feb 13, 2012

I will track the fix over in r.js issue 94.

@jrburke jrburke closed this as completed Feb 13, 2012
@DashBDev
Copy link
Author

Thanks, this seems to work now. However, I notice that a relative dir on the command line seems to start from the current working directory whereas a relative dir in the build.js file is based off the location of the build.js file. Is this expected?

@jrburke
Copy link
Member

jrburke commented Feb 15, 2012

Yes, that is the expected behavior for the "dir" config option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants