Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that GLBC's canonical RBAC ClusterRole is pruned, explained, tested #743

Open
dekkagaijin opened this issue May 1, 2019 · 3 comments
Open

Ensure that GLBC's canonical RBAC ClusterRole is pruned, explained, tested #743

dekkagaijin opened this issue May 1, 2019 · 3 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dekkagaijin
Copy link

dekkagaijin commented May 1, 2019 •
edited
Loading

https://github.com/kubernetes/ingress-gce/blob/master/docs/deploy/resources/rbac.yaml

The canonical RBAC permissions should be kept minimal, up-to-date, explained (e.g. link permissions to lines in source code) and tested. For example, ingresses resources are moving under the networking.k8s.io group and it's unclear which core APIs actually require write permissions and which only need read.
@dekkagaijin
Copy link
Author

/assign rramkumar1
@dekkagaijin dekkagaijin mentioned this issue May 1, 2019
Merged
@dekkagaijin dekkagaijin changed the title Ensure that the canonical RBAC ClusterRole is pruned, tested May 1, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2019
@rramkumar1 rramkumar1 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 31, 2019
@freehan
Copy link
Contributor

freehan commented Jan 4, 2022

The rbac has mostly went stale. Need to switch to use RBAC in K/K as the canonical one.
@freehan freehan added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
5 participants
@dekkagaijin @freehan @k8s-ci-robot @rramkumar1 @fejta-bot