Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioTransforms are dropped when saving MixedCuts? #1367

Open
m-wiesner opened this issue Jul 3, 2024 · 1 comment
Open

AudioTransforms are dropped when saving MixedCuts? #1367

m-wiesner opened this issue Jul 3, 2024 · 1 comment

Comments

@m-wiesner
Copy link
Contributor

Perhaps this wasn't the intended usage of MixedCuts, but it seems that if you mix cuts to which audio transforms have been applied and then try to save the mixed cuts, the transform types (names) are dropped when they are transform objects instead of dictionaries.

In MonoCuts there doesn't seem to be a problem. I assume that this is because the transforms are saved in the Cuts that are stored in the MixedCut tracks and not in the transform field of the MixedTrack, which makes sense because each track could have different transforms applied to it, but I think it is causing a problem with serialization.

Specifically, when the object gets passed to the dataclasses asdict function, it doesn't seem to store the type of transform when the transform is specified as an AudioTransform object. It just stores the fields.

@pzelasko
Copy link
Collaborator

pzelasko commented Jul 3, 2024

I forgot that mixed cut also has a transforms field now. We’ll need to add test coverage for this too. Do you have some time to fix? Otherwise I’ll do it but probably only after the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants