Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement caching to avoid "Too many requests" error #4

Open
natenho opened this issue Sep 1, 2019 · 1 comment
Open

Implement caching to avoid "Too many requests" error #4

natenho opened this issue Sep 1, 2019 · 1 comment

Comments

@natenho
Copy link

natenho commented Sep 1, 2019

Hi, I was building a project to extract data from Nubank API when I found yours, which was surprisinly similar to mine. I'll go with your implementation for now on, thanks!

Here is one suggestion: Implement some caching to avoid "Too Many Requests" occuring. It could have a default configuration (e.g. cache everything for 30 minutes).

A good caching implementation using Polly:
https://github.com/App-vNext/Polly/wiki/Cache

What do you think?
I'd be glad to contribute if you're interested 👍
@lira92
Copy link
Owner

lira92 commented Sep 2, 2019

Hi @natenho, nice idea, I'm glad to see that you want to contribute to this project. I think that the cache is a very nice idea, feel free to sendo a PR with your implementation. I didn't have much time to work on this project recently, the tests in the develop branch are broken, and I will try to fix this for you, sorry for this 😞.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@natenho @lira92