node, sdk/node: add options to configure reconnection backoff #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didip
reviewed
Jul 4, 2020
| Services map[string]flatend.Handler | ||
|
|
||
| // Total number of attempts to reconnect to a peer we reached that disconnected. | ||
| // Default is 8 attempts, set to a negative integer to not attempt to reconnect at all. |
There was a problem hiding this comment.
Can 0 be no reconnect and -1 be forever retry?
There was a problem hiding this comment.
I tried to figure a way to do that, though I wonder how we could force the default value for NumReconnectAttempts to be 8 in that case. The only idiomatic way I could think of is to switch to functional options, or to encapsulate options into a separate Options struct with sensible defaults, though might you have any suggestions?
There was a problem hiding this comment.
When I do services in Go, typically I create some kind of config object which can be use by main.go. So the main program is the one that is setting the defaults. User can then set parameters on main.go to override the defaults.
…0 will attempt to retry infinitely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.