Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JSDom v16+ #12185

Open
mourner opened this issue Aug 23, 2022 · 0 comments
Open

Upgrade to JSDom v16+ #12185

mourner opened this issue Aug 23, 2022 · 0 comments

Comments

@mourner
Copy link
Member

mourner commented Aug 23, 2022

Currently GL JS uses jsdom v13.2.0 (Sep 2019) in dev dependencies. To keep deps up to date, we need to upgrade to a newer version, but v16 (Jan 2020) is a big overhaul that introduces a major breaking change: different instances of JSDOM window don't share the same prototypes of classes, meaning that our approach to resetting window stubs by creating a new instance (see window.js) no longer works properly — breaking about 700 unit tests. Upgrading won't be trivial, but it's necessary if we want to keep GL JS dev environment up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant