Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky text-variable-anchor render tests #8679

Open
Tracked by #11732
mourner opened this issue Aug 22, 2019 · 3 comments
Open
Tracked by #11732

Fix flaky text-variable-anchor render tests #8679

mourner opened this issue Aug 22, 2019 · 3 comments

Comments

@mourner
Copy link
Member

mourner commented Aug 22, 2019

text-variable-anchor/pitched-with-map render test failed in a commit that just changed the changelog, so it's apparently flaky (it passed after rerunning the tests) — let's investigate. cc @alexshalamov

image

@alexshalamov
Copy link
Contributor

alexshalamov commented Aug 22, 2019

@mourner Just tried running gl-native tests

for i in {1..20}; do build/linux-x86_64/Release/mbgl-render-test text-variable-anchor -r --shuffle --seed=$RANDOM; done

image

Really strange that it is flaky on gl-gs, we had few flaky tests in native, as the rendering results were created in gl-js and native uses floats in placement code (double in gl-js).

@mourner mourner changed the title Fix flaky text-variable-anchor/pitched-with-map render test Aug 28, 2019
@mourner
Copy link
Member Author

mourner commented Aug 28, 2019

Another example of a flaky test, this time it's text-variable-anchor/pitched — the pattern of failure is very similar:

image

@kkaefer
Copy link
Contributor

kkaefer commented Sep 21, 2019

Got another instance of this. @arindam1993, @alexshalamov let's fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants