Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maptalks is not defined in requirejs #628

Closed
lifefriend opened this issue Mar 7, 2018 · 2 comments
Closed

maptalks is not defined in requirejs #628

lifefriend opened this issue Mar 7, 2018 · 2 comments
Assignees
@fuzhenn
Labels
bug good first issue

Comments

@lifefriend
Copy link
Contributor

lifefriend commented Mar 7, 2018 •
edited by fuzhenn
Loading

maptalks's version and what browser you use?

maptalks-0.38.2

Issue description

when edit rectangle in requirejs

Uncaught ReferenceError: maptalks is not defined
   at Circle.getOutline (maptalks.js:11969)
    at GeometryEditor._createOrRefreshOutline (maptalks.js:21887)
    at GeometryEditor.start (maptalks.js:21795)
    at Circle.startEdit (maptalks.js:23170)

change "return new maptalks.Polygon" to "return new Polygon" can fix it in function "Path.prototype.getOutline"

Please provide a reproduction URL (on any jsfiddle like site)
@fuzhenn fuzhenn self-assigned this Mar 7, 2018
@fuzhenn
Copy link
Member

fuzhenn commented Mar 7, 2018

Confirmed, really thanks!
@fuzhenn fuzhenn closed this as completed in 3ba2c00 Mar 7, 2018
@fuzhenn
Copy link
Member

fuzhenn commented Mar 7, 2018

Fixed and published as v0.39.1
Thanks again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue
2 participants
@fuzhenn @lifefriend