Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline comments not appearing on the 'Files Changed' tab in GitHub using GitHub workflows #920

Open
JordanR-img opened this issue Jun 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@JordanR-img
Copy link

Hi Michael,

Firstly, thank you for providing this plugin and the time and effort you have put into this!

We have been having an issue while using your plugin, it seems that inline comments on GitHub are not being populated in the files changed tab. (Though we're still receiving the SonarQube summary)

This has worked in the past when we have used the same version of the plugin (SonarQube 9.9.2 LTS and 1.14.0 Community Branch Plugin) but were using the ADO tasks (sonarqubePrepare@5, sonarqubePublish@5). The code being stored in GitHub whilst the pipeline was in ADO, this populated the comments in GitHub and worked as it should.

Upon moving to GitHub workflows and connecting to SonarQube via a GitHub app, the comments are not being populated on GitHub. We have tested this with

  • SonarQube 10.3 with community branch plugin 1.18.0
  • SonarQube 10.4 with community branch plugin 1.19.0

We are following the manual install steps that you specify in your readme

Is this expected behaviour? Is there something we could possibly be missing when moving to GitHub workflows?

@JordanR-img JordanR-img added the bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant