Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many node / nonblocking connect fails #1484

Open
aviramha opened this issue May 30, 2023 · 2 comments
Open

many node / nonblocking connect fails #1484

aviramha opened this issue May 30, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@aviramha
Copy link
Member

when running the many requests tests on node, we get stuck only on the part of "connect" and until we get to the part where we write the connection times out.
Right now even if the socket is nonblocking, we block until we get a response.
The solution would probably be to move the part of creating a local socket and listening on it to be before we even send the request, then not block for answer for connect when socket is nonblocking. One issue is that we need to set the local address that comes from the remote - we can do it when the connection is actually made since I assume none will call getsockname before it succeeds.
Another part of the solution would be to make the agent connect as part of the socket handling socket, so it itself wont block until the connect is done.

@eyalb181
Copy link
Member

eyalb181 commented Aug 8, 2023

Pending protocol revamp #1353

@eyalb181
Copy link
Member

@infiniteregrets Any chance this was solved by @Razz4780 's internal proxy refactor? Could you retest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
3 participants