Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration sanity tests for Rails #199

Open
eyalb181 opened this issue Jul 11, 2022 · 3 comments
Open

Add integration sanity tests for Rails #199

eyalb181 opened this issue Jul 11, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers tests

Comments

@eyalb181
Copy link
Member

At the time of writing, we run our e2e test flows on test apps in Node and Python (Flask). We should expand coverage to include more frameworks (since different web frameworks occasionally use libc/syscalls in different ways). Please implement the existing tests for a basic Ruby on Rails app.
@eyalb181 eyalb181 added enhancement New feature or request good first issue Good for newcomers labels Jul 11, 2022
@eyalb181 eyalb181 added the tests label Sep 19, 2022
@IsaacCloos IsaacCloos mentioned this issue Oct 16, 2022
Closed
5 tasks
@aviramha aviramha changed the title Add e2e sanity tests for Rails Oct 23, 2022
@choznerol
Copy link

choznerol commented Mar 11, 2024 •
edited
Loading

Just curious, since Flask was chosen over Django for testing Python, would you share more on the choice between Rails and Sinatra for testing Ruby? Thanks!
@eyalb181
Copy link
Member Author

No real reason, we just figured Rails is more popular. We'd welcome Sinatra tests just the same.
The Flask choice was for a different reason - some users ran into issues with it specifically.
@choznerol
Copy link

choznerol commented Mar 12, 2024 •
edited
Loading

Got it. Thanks for the explaination!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers tests
2 participants
@eyalb181 @choznerol