Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Chunked Messages in HTTP Header Filter #929

Open
t4lz opened this issue Jan 10, 2023 · 2 comments
Open

Support Chunked Messages in HTTP Header Filter #929

t4lz opened this issue Jan 10, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@t4lz
Copy link
Member

t4lz commented Jan 10, 2023

Currently we collect the whole message (request in the agent, response in the layer) before forwarding it, which means we do not support real streaming over HTTP with the HTTP Header Filter.

We should introduce new messages to the mirrord protocol, and if a message is chunked, forward the chunks in both directions as they come.

@t4lz t4lz added the enhancement New feature or request label Jan 10, 2023
@aviramha
Copy link
Member

Need to understand if this is relevant to HTTP2 as well - in that case, have HTTP2 as another issue.

@gememma
Copy link
Contributor

gememma commented May 29, 2024

The diferences between HTTP1 and 2 are irrelevant at the point where this gets handled, so no special considerations are needed. I will however create separate issues regarding HTTP requests and HTTP responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
3 participants