'declare method' quick fix for adding a private method

[mjbvz]

From microsoft/vscode#94118

TypeScript Version: 3.9.0-dev.20200330

Search terms

• quick fix
• declare method
• private

Repro
For ts file:

index.ts

class Bar {
    bar() {
         this._baz(123)
    }
}

1. Trigger quick fixes on _baz

Feature request:
#36249 added a quick fix for adding private properties. However there is no quick fix for adding a private method

Playground Link:

Related Issues:

• Declare property quick fix should add private properties (or be configurable)  #36249

[bpasero]

I am the original one complaining about this: what I expect is NOT having 1 code action per visibility, but rather ONE code action (as today) with a tab-stop at the visibility that I can flip the various visibilities. I realise this may need support from VSCode too. Here is how it would work:

• you trigger the code action
• you get into a mode like snippets where certain places are stops you can cycle through with Tab key
• each method or property has a tab stop where you can navigate to and once you are there, be able to select a modifier private, protected, public etc.

[a-tarasyuk]

@DanielRosenwasser Is there a way to have a sub action to handle tab-stop? Or need to generate all possible actions for various methods/properties and VSCode should resolve tab-stop? Do I need to close #37806, and revert #36249?

[DanielRosenwasser]

Could you explain what you mean by tab-stop? I feel like I have an idea, but I might be out of the loop on something.

[a-tarasyuk]

@bpasero

Could you explain what you mean by tab-stop?

[mjbvz]

Tabstops are from VS Code's snippets: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_tabstops

There is no concept of tabstops in the TS Server api today since it only talks about text. I've opened #25207 which proposes adding the idea of snippets to typescript

[a-tarasyuk]

Right now I see two ways for this issue

1. Resolve this issue based on the original requirements
2. Close feat(37782): 'declare method' quick fix for adding a private method #37806 revert Declare property quick fix should add private properties (or be configurable)  #36249 and add tab-stop for modifiers after TSServer: snippet completions #25207 will be implemented

I feel like I have an idea

@DanielRosenwasser Maybe you have a better idea :)

[DanielRosenwasser]

Hah, I meant like "I might have an idea of what you mean by tab stops". I think the weird thing is that the rename location already allows you to make something #-private, but it's not clear whether we could make a conditional tabstop location for when the declaration isn't #-private

[bpasero]

To demonstrate what I expect to happen, here is what Eclipse does:

Notice how some tab-stops are linked, so renaming the method actually also renames the call!

And what VSCode does:

Paper cuts:

• method is added above constructor???
• no way to change anything after the method was inserted

Can we reopen this or reconsider this?

[sandersn]

Yeah, #37806 partially fixes this but doesn't address the full issue. I'll re-open that so we can unify the two fixes when post-codefix rename locations are available.

[arvind-nikam-halodoc]

From microsoft/vscode#94118

TypeScript Version: 3.9.0-dev.20200330

Search terms

• quick fix
• declare method
• private

Repro
For ts file:

index.ts

class Bar {
    bar() {
         this._baz(123)
    }
}

1. Trigger quick fixes on _baz

Feature request:
#36249 added a quick fix for adding private properties. However there is no quick fix for adding a private method

Playground Link:

Related Issues:

• Declare property quick fix should add private properties (or be configurable)  #36249

It’s fixed i guess.