Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ISPC be a well-known tool? #26965

Closed
Tradias opened this issue Sep 24, 2022 · 5 comments · May be fixed by #29261
Closed

Should ISPC be a well-known tool? #26965

Tradias opened this issue Sep 24, 2022 · 5 comments · May be fixed by #29261
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity. Stale

Comments

@Tradias
Copy link
Contributor

Tradias commented Sep 24, 2022

I am planning on contributing the port files of OSPRay, OpenVLK and rkcommon that I have created. They depend on ISPC. I currently use find_program in their port files to acquire the system installed variant of it, but that will certainly not work for the vcpkg pipelines here. Therefore my question, how to best handle it? Adding it to vcpkg_find_acquire_program sounds like an option, but since ISPC is a compiler, I am not sure that is the right place (seeing that compilers are generally expected to be provided through toolchain files).

See also previous issues on ISPC: #15846, #8698
@LilyWangLL LilyWangLL self-assigned this Sep 26, 2022
@LilyWangLL
Copy link
Contributor

Thanks for posting this issue, you can add it like vcpkg-tool-meson or vcpkg-tool-gn.
@LilyWangLL LilyWangLL added category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels Sep 26, 2022
@LilyWangLL LilyWangLL removed their assignment Sep 27, 2022
@JonLiu1993
Copy link
Member

Fixing by PR #29261
@JonLiu1993 JonLiu1993 linked a pull request Feb 8, 2023 that will close this issue
[ispc] Add new port. #29261
Draft
11 tasks
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.
@github-actions github-actions bot added the Stale label Jul 5, 2023
@LilyWangLL LilyWangLL removed the Stale label Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.
@github-actions github-actions bot added the Stale label Sep 4, 2023
@LilyWangLL LilyWangLL removed the Stale label Sep 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.
@github-actions github-actions bot added the Stale label Nov 4, 2023
@github-actions github-actions bot added the info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity. label Nov 18, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity. Stale
3 participants
@Tradias @JonLiu1993 @LilyWangLL