Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-kinect-sensor-sdk] Build error #33137

Open
thundercarrot opened this issue Aug 13, 2023 · 2 comments · May be fixed by #33992
Open

[azure-kinect-sensor-sdk] Build error #33137

thundercarrot opened this issue Aug 13, 2023 · 2 comments · May be fixed by #33992
Assignees
@Adela0814 @jimwang118
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@thundercarrot
Copy link

Package: azure-kinect-sensor-sdk[core,tool]:x64-windows -> 1.4.1#5

Building with "tool" feature fails. ImGui's SetNextTreeNodeOpen was previously deprecated and now has been removed. Call SetNextItemOpen instead.

see https://github.com/ocornut/imgui/blob/1362fc0c56d8742167379661a353d8342f7c4a86/imgui.h#L3131

As an aside, I was on the way to creating a patch and PR for it, but without --editable support in manifest mode, this seems pretty onerous. Is there a recommended way to do this?

Host Environment

  • Host: x64-windows
  • Compiler: MSVC 19.37.32822.0
  • vcpkg-tool version: 2023-06-15-8c254a5fb6c503615834fc66bd0717664a339a2e
    vcpkg-scripts version: 0fa8459 2023-08-11 (2 days ago)

To Reproduce

vcpkg install

Failure logs

buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4adevicedockcontrol.cpp(336): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui'
buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4asourceselectiondockcontrol.cpp(37): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui'
@Adela0814 Adela0814 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 14, 2023
@Adela0814
Copy link
Contributor

Adela0814 commented Aug 14, 2023 •
edited
Loading

Confirmed, I can repro this in my side.
@jimwang118 jimwang118 mentioned this issue Aug 17, 2023
Closed
7 tasks
@jimwang118 jimwang118 linked a pull request Sep 25, 2023 that will close this issue
Draft
7 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.
@github-actions github-actions bot added the Stale label Mar 9, 2024
@jimwang118 jimwang118 removed the Stale label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
3 participants
@thundercarrot @Adela0814 @jimwang118