Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libcoro] It is unclear how to use this port #37697

Open
dasmysh opened this issue Mar 25, 2024 · 3 comments · May be fixed by #37730
Open

[libcoro] It is unclear how to use this port #37697

dasmysh opened this issue Mar 25, 2024 · 3 comments · May be fixed by #37730
Assignees
@LilyWangLL
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@dasmysh
Copy link

dasmysh commented Mar 25, 2024

Is your feature request related to a problem? Please describe.

I am trying to use libcoro in one of my projects, but due to the lack of a libcoroConfig.cmake file can not perform a find_package in CMake. I am not sure if I am overseeing something here but in the current state the port feels kind of incomplete.

Proposed solution

Provide a libcoroConfig.cmake file that exposes a target that can be used to link against in CMake.

Describe alternatives you've considered

No response

Additional context

No response
@dasmysh dasmysh added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 25, 2024
@dasmysh
Copy link
Author

dasmysh commented Mar 26, 2024

I am currently trying to figure out how to best fix this to create a PR. I guess it is best to create these files during cmake install. So I will try to fix this in the libcoro repository and first create a PR there, and then probably (depending on how fast that gets merged) provide a PR with a patch file for what I did there in vcpkg.
@LilyWangLL
Copy link
Contributor

libcoro provide the pc file, you could use it as the following usage:

    find_package(PkgConfig REQUIRED)
    pkg_check_modules(test REQUIRED IMPORTED_TARGET libcoro)
    target_link_libraries(main PkgConfig::test)
@dasmysh dasmysh linked a pull request Mar 26, 2024 that will close this issue
Draft
7 tasks
@dasmysh
Copy link
Author

dasmysh commented Mar 26, 2024

That looks like a great option, but I think it would be nice to have usage instructions for that. I created a pull request that adds those instructions as a draft. Would be great to get some feedback on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
2 participants
@dasmysh @LilyWangLL