the build outputs an error message when it actually succeeds.

@davidmatson Thanks for posting this issue, could you please provide me with the error log you output?

Command="cmd /c pwsh.exe $(_ZVcpkgAppLocalPowerShellCommonArguments) >NUL 2>&1"

This will only cover up the error but not fix it. 🤔

the build outputs an error message when it actually succeeds.
@ davidmatson Thanks for posting this issue, could you please provide me with the error log you output?

Sure; the error message is simply:

'pwsh.exe' is not recognized as an internal or external command,

Command="cmd /c pwsh.exe $(_ZVcpkgAppLocalPowerShellCommonArguments) >NUL 2>&1"
This will only cover up the error but not fix it. 🤔

I think the problem is just that the current command attempts to invoke a program that may or may not exist, and then uses the exit code to tell whether it did or not, but that command will naturally error out if the program doesn't exist. If the command is intended just to see if it will fail or not, having the "error" message output isn't great.

Another option would be to use where:

Command="cmd /c where pwsh.exe $(_ZVcpkgAppLocalPowerShellCommonArguments) >NUL 2>&1"

But redirecting stderr is still necessary; where also outputs text to stderr if the program does not exist.
If the goal is to determine whether the command exists, I don't think suppressing error output hides the problem; the problem is the spurious error message in build logs.

I think the following code can serve as a temporary workaround.

    <!-- Search %PATH% for pwsh.exe if it is available. -->
    <Exec
      Condition="'$(VcpkgXUseBuiltInApplocalDeps)' != 'true'"
      Command="pwsh.exe $(_ZVcpkgAppLocalPowerShellCommonArguments) 2&gt;NUL"
      IgnoreExitCode="true"

$(_ZVcpkgAppLocalPowerShellCommonArguments) may generate output.
Since we only want to ignore the error output, 2>NUL is preferable to >NUL 2>&1.

May I make a pull request?

This issue may caused by 11610ea(#35012).

vcpkg.props defines $(VcpkgXUseBuiltInApplocalDeps) as false,
but noone defines $(VcpkgXUseBuiltInApplocalDeps) as true.

@FrankXie05

The cause of the bug lies in the following part.

At line 229, it incorrectly calls pwsh.exe without checking if pwsh.exe is included in the %PATH%.

On Windows, when you want to check if a specific command is in the %PATH%, you can use the WHERE command.

By inserting the following code snippet before line 229, the bug can be resolved.

      Command="where.exe pwsh.exe >NUL 2>&1"
      IgnoreExitCode="true"
      UseCommandProcessor="false">
      <Output TaskParameter="ExitCode"
              PropertyName="_ZSearchPwshInPathExitCode" />
    </Exec>
    <!-- Execute PowerShell Core commands to ensure compatibility with legacy code. -->
    <Exec
      Condition="'$(_ZSearchPwshInPathExitCode)' == '0'"

At line 229, just rename from pwsh.exe to powershell.exe