Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What methods can be used in place of updateMarker now that the virtual tour plugin does not use markers? #1348

Closed
AndyBaird opened this issue Jul 1, 2024 · 2 comments

Comments

@AndyBaird
Copy link

Describe your problem

In our usage we have allowed users to move markers in a virtual tour with a few "move" buttons that would call the markersPlugin.updateMarker method and save the updated linkOffset. Now that the virtual tour plugin does not use markers, none of that functionality will work.

I am not seeing an alternative method in the virtualTourPlugin API documentation that would allow for these marker/arrows to be moved in real-time anymore. Does a new method need to be added or is there a way to do this that I am not understanding?

Online demo URL

No response

Photo Sphere Viewer version

5.8.1

Plugins loaded

No response

Additional context

No response

@mistic100
Copy link
Owner

mistic100 commented Jul 3, 2024

If you are building an UI to create a virtual tour I would suggest to only use the markers plugin during the configuration phase, save the various coordinates, then switch to the virtual tour plugin in production.

However you should be able to update the links by calling setNodes, this requires to overwrite all the nodes, but it should not be a problem.

Manually updating the generated markers was not intended.

Copy link

This issue has been automatically marked as stale because not enough information was provided. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment