Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Do not open new player session and replace old one when opening the same media #389

Open
ghost opened this issue Nov 11, 2022 · 6 comments

Comments

@ghost
Copy link

ghost commented Nov 11, 2022

When using local media, the subtitles are reset when miminizing the app. When sharing media from Jellyfin android app as an external player to Just player, both the subtitles and the audio are reset to their automatic settings.

@moneytoo
Copy link
Owner

I believe that in this case the selection is controlled by Jellyfin.

@ghost
Copy link
Author

ghost commented Dec 8, 2022

@moneytoo Subtitles are still reset with local media though.

@moneytoo
Copy link
Owner

moneytoo commented Dec 9, 2022

Please describe the steps (ideally with a media sample) to reproduce this issue.

@ghost
Copy link
Author

ghost commented Dec 10, 2022

I think I figured out the issue. If I open a media from a file manager, play it, then modify the default value of subtitles and open the same media again from the manager, even though the player is already open and has the media available, it just probably gets replaced by the new opening of that media with the default settings. I did not notice this because of the (wonderful) play history implementation, so I thought the playing media did not get replaced by the opening one. I thought this issue was caused by minimizing because even though I minimized the app, I never opened it back from the app history (already opened apps) menu, but tapped on the file manager icon which was on my homescreen (the player was not) and reopened the media from there, thus creating a new instance.

@ghost
Copy link
Author

ghost commented Dec 10, 2022

I hope what I wrote could be understood. With this in mind I would modify the issue.

@ghost ghost changed the title [BUG] Subtitles and audio channels are reset to default when minimizing the app Dec 10, 2022
@ghost
Copy link
Author

ghost commented Dec 10, 2022

What I would suggest instead is if the newly opened media is the same that is currently being played, just continue that instance (session). This can spare resources, time and fixes this issue.

@moneytoo moneytoo reopened this Dec 10, 2022
@ghost ghost changed the title [Suggestion] Do not open new player session and replace old one when opening the same media is requested to be played Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant