Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Hearbeat Loops #177

Open
brstgt opened this issue Nov 2, 2014 · 1 comment
Open

Infinite Hearbeat Loops #177

brstgt opened this issue Nov 2, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@brstgt
Copy link

brstgt commented Nov 2, 2014

Hi there,

I use an existing Android lib, that sends a heartbeat packet based on a regular interval. The server reacts on this packet with a heartbeat packet, then again the client answers with a heartbeat packet.
Every e.g. 30s the client sends a new heartbeat packet. This results in an infinite number of heartbeat loops as every 30s is created a new loop.
I use 1.6.5 because 1.7.x did not work with our existing clients.

I think this could be easily fixed by using a keyed scheduler in HeartbeatHandler.

Do you still maintain that version? What would you recommend me to do? I would easily be able to fix that issue in a fork but if you have a simpler solution, I also would be glad.

Thanks for your help!
Benjamin

@brstgt
Copy link
Author

brstgt commented Nov 3, 2014

I fixed it in this patch but can't create a pull request from it:

https://github.com/Jaumo/netty-socketio/commit/b4b3f0204cd076c56f8eed250d8d2fb1202d44b4

@mrniko mrniko added the bug label Nov 3, 2014
@mrniko mrniko added this to the 1.6.6 milestone Nov 3, 2014
@mrniko mrniko self-assigned this Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants