-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 onOutputOrientationChanged outputs wrong value on tablets #2984
Comments
Guten Tag, Hans here. Note New features, bugfixes, updates and other improvements are all handled mostly by |
I need the log output. I need to know what happens on the native side and what orientations are computed. If you leave this out, I cannot help you. If you add this, we can reopen the issue. |
The log output is what happens when going from portrait (selfie camera left) to landscape (selfie camera top) |
Great, thanks! I'll try to take a look at this sometime soon. Not sure when I'd have the time for that. |
When you say "Preview" in your issue, you mean "Captured Photo", not "Preview" right? The term "Preview" means live preview view for me. |
@mrousavy Exactly. I've updated the labelling to avoid confusion. |
Hm, to be honest I don't think there's anything I'm doing wrong. I think this is either a bug of the Android Emulator you are using, or the Camera2 HAL implementation of that Tablet, or CameraX - but there's no explicit portrait handling on my end. |
What's happening?
On Android tablet, this
onOutputOrientationChanged
event emits"portrait"
when it should be"landscape"
and viceversa. (See screenshots and console warns)My issue is that the output of the photo taken in landscape mode is always 3/4 (vertical/portrait) while the output of the photo taken in portrait mode is always 4/3 (horizontal/landscape) and I suspect this happens due to the wrong orientation calculated by the library.
I've tried using
format
and it wasn't working either.Captured photo:
Captured photo:
Reproduceable Code
Relevant log output
Camera Device
Device
Pixel Tablet API 34
VisionCamera Version
4.2.1
Can you reproduce this issue in the VisionCamera Example app?
Yes, I can reproduce the same issue in the Example app here
Additional information
The text was updated successfully, but these errors were encountered: