Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal state in all input components #101

Open
mxdi9i7 opened this issue Jan 7, 2021 · 0 comments
Open

Remove internal state in all input components #101

mxdi9i7 opened this issue Jan 7, 2021 · 0 comments

Comments

@mxdi9i7
Copy link
Owner

mxdi9i7 commented Jan 7, 2021

We are currently managing input state in 2 places, the parent component as well as the input component itself.

To keep 1 single source of truth and avoid bugs like #83. We need to remove all internal state in input components and force users to manage input states themselves using parent's component.

Acceptance criteria:
All input components' states need to be managed from the outside, there should be no side-effect inside the component that could alter the input state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant