Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found some hard-coded dimensions, not sure if it's an issue or not (yet) #69

Open
NimrodCarmon opened this issue Mar 22, 2021 · 0 comments

Comments

@NimrodCarmon
Copy link

in frameworker.cpp, in the frameworker function (starts at line 68), we have this:

case XIO:
    Camera = new XIOCamera(settings->value(QString("ssd_width"), 640).toInt(),
                           settings->value(QString("ssd_height"), 480).toInt(),
                           settings->value(QString("ssd_height"), 480).toInt());
    break;
case ENVI:
    Camera = new ENVICamera(settings->value(QString("ssd_width"), 640).toInt(),
                            settings->value(QString("ssd_height"), 480).toInt(),
                            settings->value(QString("ssd_height"), 480).toInt());

It might be nothing, but I wanted to put it here so people would be aware in case there are downstream issues from this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant