Use Common Files in all Components

[sheershak-agarwal]

Hello,

I want to use some common c++ files in all my components.

What I did:

1. created a new folder common
2. add my cpp and h files in the common folder
3. added CmakeLists.txt in the Common folder saying
   set(SOURCE_FILES
   "${CMAKE_CURRENT_LIST_DIR}/Common.cpp"
   )
   register_fprime_module()
4. add #include "App/Common/Common.h" on top of ComponentImpl.cpp
5. added add_fprime_subdirectory("${CMAKE_CURRENT_LIST_DIR}/Common/") in the Main CmakeLists.txt

but when I build it cannot find the Common.h file.
I have also tried it without the CmakeList.txt file. How can add a file in a common folder and then add use those in my ComponentImpl design?

[timcanham]

The header file dependencies don't work quite right yet, so you have to add:

set(MOD_DEPS
  Path/ToLibrary
)

To your CmakeList.txt for the component(s) that depend on it.

[sheershak-agarwal]

I added to my component
set(MOD_DEPS
"App/Common/StateMachine.cpp"
)
but I see this error:
CMake Error at /home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/support/Module.cmake:94 (add_dependencies):
-- Generating done
The dependency target "App_Common_StateMachine.cpp" of target
"App_MissionStateManager" does not exist.
Call Stack (most recent call first):
/home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/support/Module.cmake:146 (generate_module)
/home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/API.cmake:182 (generate_library)
MissionStateManager/CMakeLists.txt:9 (register_fprime_module)

[sheershak-agarwal]

Still getting this error:

CMake Error at /home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/support/Module.cmake:94 (add_dependencies):
-- Generating done
The dependency target "App_Common" of target "App_MissionStateManager" does
not exist.
Call Stack (most recent call first):
/home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/support/Module.cmake:146 (generate_module)
/home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/API.cmake:182 (generate_library)
MissionStateManager/CMakeLists.txt:10 (register_fprime_module)

[Joshua-Anderson]

Do you have a CMakeLists.txt file defining a component in App/Common?

[sheershak-agarwal]

No(its not a component but just c++ files), so should I add one and should I also added add_fprime_subdirectory("${CMAKE_CURRENT_LIST_DIR}/Common/") in the Main CmakeLists.txt

[Joshua-Anderson]

Yep, exactly. Add a CMakeLists.txt file with the cpp file as a source file and declaring a module, then add it to the parent directory's CMakeLists.txt file.

[sheershak-agarwal]

Thank you for that. It compiles perfectly now.

[timcanham]

Sorry - to clarify, you put the directory in the MOD_DEPS. For you:

set(MOD_DEPS
  App/Common
)

[sheershak-agarwal]

I still get an error:
CMake Error at /home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/support/Module.cmake:94 (add_dependencies):
-- Generating done
The dependency target "App_Common" of target "App_MissionStateManager" does
not exist.
Call Stack (most recent call first):
/home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/support/Module.cmake:146 (generate_module)
/home/sheershak/Desktop/F-Prime-Debug/fprime/cmake/API.cmake:182 (generate_library)
MissionStateManager/CMakeLists.txt:10 (register_fprime_module)

[timcanham]

There is probably something off in the pathnames. Can you show your directory structure and where the cmake files are?

[sheershak-agarwal]

https://github.com/sheershak-agarwal/F-Prime-Debug
and the edit I made is in https://github.com/sheershak-agarwal/F-Prime-Debug/blob/main/App/MissionStateManager/CMakeLists.txt

[LeStarch]

I may be late to the game here but it looks like the steps you are following are ok.

1. Add CMakeLists to App/Common
2. Add MOD_DEP of "App/Common" to MissionStateManager
3. (Did you do this) Add "add_fprime_subdirectory(/path/to/common)" to "App/CMakeLists.txt"