Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async-hooks.test-emit-before-on-destroyed is flaky #50262

Closed
anonrig opened this issue Oct 18, 2023 · 1 comment
Closed

async-hooks.test-emit-before-on-destroyed is flaky #50262

anonrig opened this issue Oct 18, 2023 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. ppc Issues and PRs related to the Power architecture.

Comments

@anonrig
Copy link
Member

anonrig commented Oct 18, 2023

Test

async-hooks.test-emit-before-on-destroyed

Platform

Linux PPC64LE

Console output

not ok 42 async-hooks/test-emit-before-on-destroyed
  ---
  duration_ms: 1008.92100
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:125
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    null !== 1
    
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/test/async-hooks/test-emit-before-on-destroyed.js:56:12)
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/test/common/index.js:476:15)
        at ChildProcess.emit (node:events:515:28)
        at maybeClose (node:internal/child_process:1105:16)
        at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: null,
      expected: 1,
      operator: 'strictEqual'
    }
    
    Node.js v21.0.0
  ...

Build links

Additional information

No response

@anonrig anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023
@github-actions github-actions bot added the ppc Issues and PRs related to the Power architecture. label Oct 18, 2023
@abmusse
Copy link
Contributor

abmusse commented Jul 2, 2024

This issue has not been occurring for a while now and seems to be related to #50245 where the solution was to un-set the test as flaky.

Perhaps we can close this issue out?

CC @mhdawson

@anonrig anonrig closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. ppc Issues and PRs related to the Power architecture.
2 participants