Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use CJS imports #374

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix: use CJS imports #374

merged 3 commits into from
Jul 20, 2023

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Jul 14, 2023 •
edited
Loading

The eventemitter-asyncresource import only works due to using esModuleInterop. However, using this flag forces all downstream consumers to also use it, polluting the entire tree.

FWIW, this is the error I get attempting to use Piscina in a project that does not set the interop option.

image
@SimenB SimenB mentioned this pull request Jul 14, 2023
Open
metcoder95
metcoder95 reviewed Jul 16, 2023
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@SimenB SimenB requested a review from metcoder95 July 20, 2023 11:58
@metcoder95 metcoder95 merged commit edf8dc4 into piscinajs:current Jul 20, 2023
10 checks passed
@SimenB SimenB deleted the use-cjs-import branch May 12, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@SimenB @metcoder95