Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CommonJS transform to cjs-module-lexer #109

Open
1 of 4 tasks
developit opened this issue Sep 30, 2020 · 1 comment · May be fixed by #874
Open
1 of 4 tasks

Switch CommonJS transform to cjs-module-lexer #109

developit opened this issue Sep 30, 2020 · 1 comment · May be fixed by #874
Milestone

Comments

@developit
Copy link
Member

developit commented Sep 30, 2020

Now that cjs-module-lexer is battle-tested (it powers CommonJS in Node as of 14.17), we should switch to it. This gives us a clean way to support CJS-->ESM transformations like we're already doing, but without the horrible regex-based implementation I cobbled together.

@developit
Copy link
Member Author

developit commented Oct 10, 2020

Looks like cjs-module-lexer won't land my require() tracking fix:
nodejs/cjs-module-lexer#10

I published the dist files (both JS and WASM) to a branch which we can vendor.

@developit developit moved this from To do to In progress in 1.0 Oct 10, 2020
@developit developit linked a pull request Nov 30, 2020 that will close this issue
@developit developit removed this from In progress in 1.0 Dec 1, 2020
@developit developit modified the milestones: 1.1, 1.2 Dec 1, 2020
@marvinhagemeister marvinhagemeister linked a pull request Sep 19, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant