Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages are installed twice if used in yarn workspace #285

Open
ghost opened this issue Dec 24, 2020 · 1 comment · May be fixed by #874
Open

Packages are installed twice if used in yarn workspace #285

ghost opened this issue Dec 24, 2020 · 1 comment · May be fixed by #874

Comments

@ghost
Copy link

ghost commented Dec 24, 2020

In yarn workspaces, all packages are installed in the node_modules folder of the workspace, not in each project's folder. Because of this, what I think is happening is that WMR is looking at the node_modules inside the project folder and because it doesn't find the requested packages there, it downloads them.

@developit
Copy link
Member

Interesting - I had assumed Yarn Workspaces would be setting up symlinks for this, but I guess they're relying on Node resolution looking into parent directories' node_modules. A prerequisite to WMR supporting this would be moving our npm cache files out of node_modules/*/.cache, which is something we already need to do in order to avoid writing to npm link'd project directories.

@marvinhagemeister marvinhagemeister linked a pull request Sep 19, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant