Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChFunctionRecorder (ChFunction_Recorder) deleted #505

Closed
cekees opened this issue Jul 5, 2024 · 2 comments
Closed

ChFunctionRecorder (ChFunction_Recorder) deleted #505

cekees opened this issue Jul 5, 2024 · 2 comments

Comments

@cekees
Copy link

cekees commented Jul 5, 2024

Hi. We have code that depends on using ChFunctionRecorder, but it appears to have been deleted in the commit below. Was that intentional? I'll disable this use case for now.

commit 95f5104
Author: DarioMangoni dariomangoni@gmail.com
Date: Tue Mar 19 17:00:04 2024 +0100

Merge branch 'feature/overhaul' into feature/modal_projection

# Conflicts:
#       src/chrono_modal/ChEigenvalueSolver.cpp
#       src/chrono_modal/ChKrylovSchurEig.cpp
#       src/chrono_modal/ChModalAssembly.cpp
#       src/chrono_modal/ChModalAssembly.h
#       src/chrono_modal/ChModalDamping.cpp
#       src/chrono_modal/ChModalDamping.h
#       src/demos/modal/demo_MOD_modal_assembly.cpp
@rserban
Copy link
Member

rserban commented Jul 5, 2024

Chris - there was a large API refactoring that happened before the 9.0 release.
All changes are documented in the CHANGELOG.

In particular, the class you mentioned (ChFunction_Recorder) was not deleted, but rather renamed to ChFunctionInterp.

@cekees
Copy link
Author

cekees commented Jul 9, 2024

Thanks!

@cekees cekees closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants