Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: browserstack/browserstack-runner Loading
base: master
Choose a base ref
...
head repository: qunitjs/browserstack-runner Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 6 files changed
  • 2 contributors

Commits on Jun 6, 2021

  1. Update js-reporters to 2.1.0

    Important changes:
    
    * Mocha 8 and later are now supported. Previously, it's pending tests
      were incorrectly reported as undefined or failing.
    
    * `QUnit.todo()` is now supported. Previously, these intentional
      failures were reported by browserstack-runner as failing tests.
    
      With js-reported 2.1 the runEnd report counts them as `todo` instead
      of as `failed`.
    
    The API that browserstack-runner depends on has not changed since 1.1.0.
    <https://github.com/js-reporters/js-reporters/blob/v2.1.0/CHANGELOG.md>.
    
    Specifically, browserstack-runner captures the following data in
    lib/_patch/reporter.js, and proccesses it in lib/server.js under
    the "_progress" and "_report" handlers:
    
    * The `testEnd` event, reading:
      - `name` string,
      - `suiteName` string,
      - `status` string,
      - `errors` array.
    
    * The `runEnd` event, reading:
      - `status` string,
      - `testCounts` object with ints `total`, `passed`, `failed`, `skipped`,
      - `runtime` int.
    
    These still exist the same way in the latest release:
    <https://github.com/js-reporters/js-reporters/blob/v2.1.0/spec/cri-draft.adoc#runend>
    
    Fixes #248.
    Ref #247.
    Krinkle committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    8d262e3 View commit details
    Browse the repository at this point in the history
  2. Fix reporting of QUnit todo tests

    The update to js-reporters 2.1.0 in the previous commit has fixed
    the most important problem, which is the build status reported
    by the `runEnd` event, handled via "_report" submission.
    
    However, the todo tests were still printed as errors in the output
    which is confusing.
    
    Before:
    
    ```
    [Windows 8, Chrome 91.0] Error: "test.todo.each [0]" failed
      Expected: true
      Actual: false
    [Windows 8, Chrome 91.0] Passed: 332 tests, 321 passed, 0 failed, 7 skipped; ran for 1255ms
    ```
    
    After:
    
    ```
    [Windows 10, Firefox 88.0] Passed: 332 tests, 321 passed, 0 failed, 7 skipped; ran for 1910ms
    ```
    
    Fixes #247.
    Krinkle committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    dab609e View commit details
    Browse the repository at this point in the history
  3. Tag 0.9.5-qunitjs.1

    Krinkle committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    019946e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    529d9db View commit details
    Browse the repository at this point in the history
  2. Tag 0.9.5-qunitjs.2

    Krinkle committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5ee0c5a View commit details
    Browse the repository at this point in the history
Loading