Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding .npmignore file #103

Closed
hakubo opened this issue Sep 27, 2014 · 4 comments
Closed

Consider adding .npmignore file #103

hakubo opened this issue Sep 27, 2014 · 4 comments

Comments

@hakubo
Copy link
Contributor

hakubo commented Sep 27, 2014

Hey,

I am a happy user of your library, but as my project grows we have a lot of dependencies.
We could save a lot of space if you added .npmignore file to your project.

I even found tool that can help you with it: https://github.com/inikulin/dmn

Thanks!

@fyockm
Copy link
Contributor

fyockm commented Oct 4, 2014

@hakubo specifically- you don't want the test directory in your node_modules?

@kof
Copy link
Contributor

kof commented Oct 4, 2014

I am not sure which files and folders need to be ignored.

  1. I never run into the issue with space
  2. Sometimes its convenient to read docs or run tests directly in the installed package
  3. Some packages even run some tests after installation
@kof
Copy link
Contributor

kof commented Oct 4, 2014

maybe we need a tool to clean up packages after installation for this ... f.e. when installing in production env.

@kof
Copy link
Contributor

kof commented Dec 23, 2014

dunno what to do here, @hakubo feel free to reopen if you want to share more insights.

@kof kof closed this as completed Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants