Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update galahad.h? #196

Open
amontoison opened this issue Nov 23, 2023 · 3 comments
Open

Update galahad.h? #196

amontoison opened this issue Nov 23, 2023 · 3 comments
Assignees
@nimgould
Labels
enhancement New feature or request

Comments

@amontoison
Copy link
Member

amontoison commented Nov 23, 2023 •
edited
Loading

I am wondering if we should not add a list of #include for all packages in the main galahad.h.
It's what is done in Intel MKL for example. The user can just add an #include "mkl.h" in its code .
@amontoison amontoison added the enhancement New feature or request label Nov 23, 2023
@nimgould
Copy link
Contributor

By this, do you simply mean adding #include "galahad_arc.h" etc? If so, yes, that is a good idea. But beware that each galahada_*.h itself includes all of the dependencies. I presume #include sorts this out
@amontoison
Copy link
Member Author

Yes, I mean that. 🙂
@nimgould
Copy link
Contributor

OK, can you do this, and check it works?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants
@nimgould @amontoison