Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace option rewriting internal require calls #245

Closed
jrburke opened this issue Aug 8, 2012 · 1 comment
Closed

namespace option rewriting internal require calls #245

jrburke opened this issue Aug 8, 2012 · 1 comment
Milestone

Comments

@jrburke
Copy link
Member

jrburke commented Aug 8, 2012

For namespace: 'foo', This:

define(function(require) {
    var a = require('./a');
});

should not be converted to:

foo.define(function(require) {
    var a = foo.require('./a');
});

but instead should be transformed to:

foo.define(function(require) {
    var a = require('./a');
});

Otherwise, local require calls will not get resolved correctly.

@jrburke
Copy link
Member Author

jrburke commented Aug 14, 2012

The builds.js test buildNamespace actually shows this problem. So fixing it so that modules/three does not have its internal require calls rewritten will be a good test case to verify the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant