-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing Dependencies ends without full completion #259
Comments
Is this using r.js 2.0.5 and are you using findNestedDependencies? If so, then there is a bug that is fixed in master, tracked in #253, and I will be doing a 2.0.6 release in the next day or two with that fix. |
Thanks. I updated from from master, to 2.0.5+ but it still seems to be doing the same. If I set |
If you have a test I can run, that would be helpful. The only other thing I can think of is if you are using the multiversion/context support and do not call the AMD APIs |
I'll see if I can break it out and reproduce it without all code for a test. I ended up reverting to what I had previous (v2.0.1) and it works. |
I've upgraded to 2.0.6 and seemed to found at least what's causing it to stop building. I'm findNestedDependencies and any file that is included using require() in my main.js, seems to get excluded from the final main.js. When I remove all requires(), all files get combined properly. Any idea what could cause this or if there's a better practice now? |
I'm not sure. If you can create a simpler test case that you can share so I can debug it, that would be very useful. But I do not know given the info above. I introduced a parse unit test for findNestedRequires here: https://github.com/jrburke/r.js/blob/master/build/tests/parse.js#L113 If your nested require calls look different from that kind of use, that might give a hint to how it fails. But having a simple test case would help demonstrate what the code looks like, what is set up in the build config. |
All of the sudden when I run
node r.js -o app.build.js
, it gets toTracing dependencies for: ./scripts/main
, but it only displays 6 files, then just continues on to showing css. There's at least 20 javascript files that used to be included in this. Any ideas how I can debug this to see why it's not continuing? No errors are being thrown.Thank you!
The text was updated successfully, but these errors were encountered: