-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression of #163, automatic use of empty:
for CDN URLs
#400
Comments
Asked for more info in the original ticket, not clear yet to me what is going wrong. |
This is a problem for me. CDN assets are not working with require JS. Particularly following the Facebook instructions for using the JDK with Require: |
@pboling do you have a sample or test I can try? Preferably something where I do not have to run requirejs-rails as I do not have that set up. Perhaps if you could pass me a simple module that uses the facebook sdk, the runtime requirejs.config you use in the browser, then the build config that is passed to r.js I could try to reproduce a test case using just r.js directly. |
I'll work on getting a simple example setup, assuming I am able to reproduce the issue outside of requirejs-rails. |
My problem seems to be a result of using almond to build my main.js, and almond not supporting CDN/external files. |
OK, yes, you can just build with require.js in that case instead of almond. You will need to set up a paths config though, and call the library something other than 'require', since 'require' is a reserved dependency name. Calling it anything else is fine, see second code snippet here for an example: |
A user of requirejs-rails has noted what appears to be a regression of a change introduced in #163, to automatically treat URLs as
empty:
in build configs. See jwhitley/requirejs-rails#87 for details. Let me know if I can be of any help in reproducing, etc.The text was updated successfully, but these errors were encountered: